Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry buffer renderer: Fix normals not transformed by the world matrix when using normal maps #15805

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 12, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 12, 2024

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crazy we never saw it

@sebavan sebavan merged commit 05d9514 into BabylonJS:master Nov 12, 2024
12 checks passed
@Popov72
Copy link
Contributor Author

Popov72 commented Nov 12, 2024

Crazy we never saw it

The problem occurred only when bump textures were used, that may be the reason why we didn't spot it earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants