Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node editors: Fix editable properties for blocks with inheritance hierarchy #15812

Merged

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 13, 2024

I had this bug in NRGE:

image

The properties of the TAAObjectRenderer are visible in the ObjectRenderer block, as both classes inherit from a base class, so all editable properties created by the TAAObjectRenderer and ObjectRenderer are added to the base class propstore.

To display only those properties that are appropriate for the selected block, the PR stores the class name together with the property data in the propstore, and checks at display time whether the property class is part of the class hierarchy of the block for which we want to display the properties.

@Popov72 Popov72 added bug nrge node render graph editor labels Nov 13, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@deltakosh deltakosh enabled auto-merge (squash) November 13, 2024 14:58
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@deltakosh deltakosh merged commit 0e7ae05 into BabylonJS:master Nov 13, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nrge node render graph editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants