Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBL shadow voxelization fix #15816

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Nov 13, 2024

Changed to onAfterRenderObservable as it seems to prevent the voxelization from failing sometimes. I think it gives time for all the RT's to become ready (shaders compiled, etc.).

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 13, 2024

@torchesburn
Copy link
Contributor

Does this mean there are shadows with HDR images used with IBL?

@sebavan sebavan merged commit f5429b7 into BabylonJS:master Nov 14, 2024
12 checks passed
@Popov72
Copy link
Contributor

Popov72 commented Nov 14, 2024

Does this mean there are shadows with HDR images used with IBL?

Yes :)

https://doc.babylonjs.com/features/featuresDeepDive/postProcesses/IBLShadowsRenderingPipeline/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants