Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another voxelization fix for IBL shadows #15825

Merged

Conversation

MiiBond
Copy link
Contributor

@MiiBond MiiBond commented Nov 14, 2024

Okay, I'm still running into cases where the voxelization never happens because the required textures aren't ready when the callback occurs.
To make this more robust, I'm allowing the call to happen as many times as it takes before everything is ready and then rendering the voxel grid and then unbinding.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 14, 2024

@Popov72 Popov72 merged commit aa30c90 into BabylonJS:master Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants