Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hotspot normal computation//add missing gizmo dispose #15829

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Nov 15, 2024

Note:
Normal is local. world matrix is used when converting from local to world. So no need to use determinant. Only Clock orientation is important here.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@CedricGuillemet CedricGuillemet changed the title Fix Hotspot normal computation Fix Hotspot normal computation//add missing gizmo dispose Nov 15, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@RaananW RaananW merged commit 8a6c6ae into BabylonJS:master Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants