Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBR material: Fix isScatteringEnabled switch not working as expected #15832

Merged
merged 1 commit into from
Nov 15, 2024

Fix isScatteringEnabled switch not working as expected

641d5cc
Select commit
Loading
Failed to load commit list.
Merged

PBR material: Fix isScatteringEnabled switch not working as expected #15832

Fix isScatteringEnabled switch not working as expected
641d5cc
Select commit
Loading
Failed to load commit list.
Azure Pipelines / CI-Monorepo succeeded Nov 15, 2024 in 11m 25s

Build #35000 had test failures

1 errors / 2 warnings

Details

Tests

  • Failed: 1 (0.04%)
  • Passed: 2,752 (99.96%)
  • Other: 0 (0.00%)
  • Total: 2,753

Annotations

Check failure on line 1417 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-Monorepo

Build log #L1417 

Bash exited with code '1'.

Check failure on line 1 in Highlights

See this annotation in the file changed.

@azure-pipelines azure-pipelines / CI-Monorepo

Highlights 

visualizationPlaywright.utils.ts:108:13 Highlights
Raw output 
  [webgpu] › visualizationPlaywright.utils.ts:108:13 › Highlights ──────────────────────────────────

    Error: Screenshot comparison failed:

      9977 pixels (ratio 0.05 of all image pixels) are different.

    Expected: /home/vsts/work/1/s/packages/tools/tests/test/visualization/ReferenceImages/highlights.png
    Received: /home/vsts/work/1/s/packages/tools/tests/test-results/visualization.webgpu-Highlights-webgpu/highlights-actual.png
        Diff: /home/vsts/work/1/s/packages/tools/tests/test-results/visualization.webgpu-Highlights-webgpu/highlights-diff.png

    Call log:
      - expect.toHaveScreenshot(highlights.png) with timeout 5000ms
      -   verifying given screenshot expectation
      - taking page screenshot
      -   disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - 9977 pixels (ratio 0.05 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - taking page screenshot
      -   disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - captured a stable screenshot
      - 9977 pixels (ratio 0.05 of all image pixels) are different.


      125 |                 expect(glError).toBe(false);
      126 |             }
    > 127 |             await expect(page).toHaveScreenshot((testCase.referenceImage || testCase.title).replace(".png", "") + ".png", {
          |                                ^
      128 |                 // omitBackground: true,
      129 |                 threshold: 0.1,
      130 |                 maxDiffPixelRatio: (testCase.errorRatio || 3) / 100,

        at /home/vsts/work/1/s/packages/tools/tests/test/playwright/visualizationPlaywright.utils.ts:127:32

    attachment #1: highlights-expected.png (image/png) ─────────────────────────────────────────────
    test/visualization/ReferenceImages/highlights.png
    ────────────────────────────────────────────────────────────────────────────────────────────────

    attachment #2: highlights-actual.png (image/png) ───────────────────────────────────────────────
    test-results/visualization.webgpu-Highlights-webgpu/highlights-actual.png
    ────────────────────────────────────────────────────────────────────────────────────────────────

    attachment #3: highlights-diff.png (image/png) ─────────────────────────────────────────────────
    test-results/visualization.webgpu-Highlights-webgpu/highlights-diff.png
    ────────────────────────────────────────────────────────────────────────────────────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────

    Error: Screenshot comparison failed:

      9977 pixels (ratio 0.05 of all image pixels) are different.

    Expected: /home/vsts/work/1/s/packages/tools/tests/test/visualization/ReferenceImages/highlights.png
    Received: /home/vsts/work/1/s/packages/tools/tests/test-results/visualization.webgpu-Highlights-webgpu-retry1/highlights-actual.png
        Diff: /home/vsts/work/1/s/packages/tools/tests/test-results/visualization.webgpu-Highlights-webgpu-retry1/highlights-diff.png

    Call log:
      - expect.toHaveScreenshot(highlights.png) with timeout 5000ms
      -   verifying given screenshot expectation
      - taking page screenshot
      -   disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - 9977 pixels (ratio 0.05 of all image pixels) are different.
      - waiting 100ms before taking screenshot
      - taking page screenshot
      -   disabled all CSS animations
      - waiting for fonts to load...
      - fonts loaded
      - captured a stable screenshot
      - 9977 pixels (ratio 0.05 of all image pixels) are different.


      125 |                 expect(glError).toBe(false);
      126 |             }
    > 127 |             await expect(page).toHaveScreenshot((testCase.referenceImage || testCase.title).replace(".png", "") + ".png", {
          |
View more details on Azure Pipelines