Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Lit in viewer lib ES6 bundle #15834

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ryantrem
Copy link
Member

Lit was added as a direct dependency of the Viewer, with the intention that it would be directly embedded as a private dependency of the Viewer to avoid any potential version conflicts (e.g. if a consuming app uses other custom elements that also use Lit). However, when it was added I missed adding the nodeResolve plugin, so it wasn't actually getting included in the bundle (it relied on the consuming app to bring in Lit). This PR fixes this, and also makes viewer package build warnings be errors so these types of issues don't slip through in the future.

@ryantrem ryantrem requested a review from RaananW November 15, 2024 21:39
@ryantrem ryantrem enabled auto-merge (squash) November 15, 2024 21:39
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 15, 2024

@ryantrem ryantrem merged commit 4c27e13 into BabylonJS:master Nov 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants