Include Lit in viewer lib ES6 bundle #15834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lit was added as a direct dependency of the Viewer, with the intention that it would be directly embedded as a private dependency of the Viewer to avoid any potential version conflicts (e.g. if a consuming app uses other custom elements that also use Lit). However, when it was added I missed adding the
nodeResolve
plugin, so it wasn't actually getting included in the bundle (it relied on the consuming app to bring in Lit). This PR fixes this, and also makes viewer package build warnings be errors so these types of issues don't slip through in the future.