Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ktx texture orientation in sandbox #15853

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

bghgary
Copy link
Contributor

@bghgary bghgary commented Nov 18, 2024

See KhronosGroup/KTX-Software#959 for full context.

The gist of it is that KTX textures are y inverted when previewing in the sandbox. The reason why is because passing in invertY of true doesn't actually work for compressed textures. I fixed it by updating the UVs of the preview plane to be OpenGL conventions so that all textures behave the same.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 18, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 19, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 19, 2024

@sebavan sebavan merged commit a1c6287 into BabylonJS:master Nov 19, 2024
12 checks passed
@bghgary bghgary deleted the sandbox-ktx-fix branch November 19, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants