Detect invalid hotspots #15865
Detect invalid hotspots #15865
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15865/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15865/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15865/merge#BCU1XR#0 |
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
|
WebGL2 visualization test reporter: |
There was previously guards in place to detect when a hotspot vertex index was out of range, and so it would just return NaN position/normal data. This change just makes sure the core hotspot functions return false when an index is out of range, and then the viewer checks the return value. Annotation elements associated with invalid hotspots are not displayed (previous logic).