Code

GLTF Serializer rework.#15869

Code

Merged

SergioRZMasson merged 152 commits intoBabylonJS:masterBabylonJS/Babylon.js:masterfrom SergioRZMasson:sergio/new-gltf-exporter-2SergioRZMasson/Babylon.js:sergio/new-gltf-exporter-2Copy head branch name to clipboardDec 4, 2024

+2,869-3,079

Commits

Commits on Oct 2, 2024

• WIP

  bghgary

  committed
  6b903c9

  Copy full SHA for 6b903c9

Commits on Oct 7, 2024

• Merge with Garys PR

  SergioRZMasson

  committed
  11ccb22

  Copy full SHA for 11ccb22

• Added triangle re-ordering logic

  SergioRZMasson

  committed
  ebac165

  Copy full SHA for ebac165

• Updated index logic to flip based on coordinate system

  SergioRZMasson

  committed
  7bc831e

  Copy full SHA for 7bc831e

Commits on Oct 8, 2024

• Added camera support

  SergioRZMasson

  committed
  c87e0ff

  Copy full SHA for c87e0ff

• Added camera export

  SergioRZMasson

  committed
  4acc5b6

  Copy full SHA for 4acc5b6

• Started adding support for skeleton

  SergioRZMasson

  committed
  c43aedb

  Copy full SHA for c43aedb

Commits on Oct 9, 2024

• Remove cameras that are not assigned to nodes

  SergioRZMasson

  committed
  1bdb0ba

  Copy full SHA for 1bdb0ba

• Added logic to not include empty or unused skins

  SergioRZMasson

  committed
  04de555

  Copy full SHA for 04de555

Commits on Oct 15, 2024

• Got skeleton working

  SergioRZMasson

  committed
  b0091a3

  Copy full SHA for b0091a3

• Merge branch 'master' of https://github.com/SergioRZMasson/Babylon.js into sergio/new-gltf-exporter-2

  SergioRZMasson

  committed
  ec11a57

  Copy full SHA for ec11a57

• Reverted changes to glTFLoader

  SergioRZMasson

  committed
  b201c4d

  Copy full SHA for b201c4d

Commits on Oct 16, 2024

• Added support for animations

  SergioRZMasson

  committed
  ba01797

  Copy full SHA for ba01797

• Added animation support

  

  --local

  committed
  0d7a705

  Copy full SHA for 0d7a705

• Changed triangle flipping to XOR operator

  SergioRZMasson

  committed
  1cc8964

  Copy full SHA for 1cc8964

• Added initial convertion to right hand mode for animation

  SergioRZMasson

  committed
  6d45c54

  Copy full SHA for 6d45c54

Commits on Oct 18, 2024

• Added right hand transformation for rotation animation

  SergioRZMasson

  committed
  d92181c

  Copy full SHA for d92181c

Commits on Oct 23, 2024

• Got morph targets to work

  SergioRZMasson

  committed
  b6658d9

  Copy full SHA for b6658d9

• Got morph to export with no errors

  SergioRZMasson

  committed
  3f5f480

  Copy full SHA for 3f5f480

Commits on Oct 24, 2024

• Solved handyness problem

  SergioRZMasson

  committed
  c8b913c

  Copy full SHA for c8b913c

Commits on Oct 25, 2024

• Init WIP

  alexchuber

  committed
  5969278

  Copy full SHA for 5969278

• Add back glTF.extensions initialization

  alexchuber

  committed
  39263db

  Copy full SHA for 39263db

Commits on Oct 28, 2024

• Add directional light test

  alexchuber

  committed
  81edf35

  Copy full SHA for 81edf35

• Changed position calculation to match old implementation

  SergioRZMasson

  committed
  5f8cd2c

  Copy full SHA for 5f8cd2c

• Removed unecessary comments

  SergioRZMasson

  committed
  350be47

  Copy full SHA for 350be47

• replace comment

  alexchuber

  committed
  d825911

  Copy full SHA for d825911

Commits on Oct 30, 2024

• Merge branch 'master' of https://github.com/SergioRZMasson/Babylon.js into sergio/new-gltf-exporter-2

  SergioRZMasson

  committed
  dede9b6

  Copy full SHA for dede9b6

• Fixed mesh flipping and removed scale flipping on animations

  SergioRZMasson

  committed
  3cd41f4

  Copy full SHA for 3cd41f4

• Update test

  alexchuber

  committed
  f70fce1

  Copy full SHA for f70fce1

• Refactor lights - WIP

  alexchuber

  committed
  9290362

  Copy full SHA for 9290362

Commits on Oct 31, 2024

• Fixed skeleton animations and fixed indices flipping

  SergioRZMasson

  committed
  313d3e9

  Copy full SHA for 313d3e9

• Ensure nodes are skippable via postExportNodeAsync, and that parent node is always "created" before children-- all to fix a light parenting issue

  alexchuber

  committed
  650ae0f

  Copy full SHA for 650ae0f

• Added logic to handle triangle flipping

  SergioRZMasson

  committed
  54cacbd

  Copy full SHA for 54cacbd

Commits on Nov 1, 2024

• Code cleanup, added missing code to push nodes to node table in the context

  SergioRZMasson

  committed
  943870a

  Copy full SHA for 943870a

Commits on Nov 4, 2024

• Fix skipping node at index 0; convert handiness of light WIP

  alexchuber

  committed
  34783e4

  Copy full SHA for 34783e4

• Fix light rotation for both LH and RH

  alexchuber

  committed
  07dd1e2

  Copy full SHA for 07dd1e2

• Fix possible empty children array (invalid glTF) if nodeIndex is null

  alexchuber

  committed
  7be933e

  Copy full SHA for 7be933e

• Update vis tests for lights

  alexchuber

  committed
  0d9aae3

  Copy full SHA for 0d9aae3

• Merge remote-tracking branch 'sergio/sergio/new-gltf-exporter-2' into ext-lights

  alexchuber

  committed
  62eea7d

  Copy full SHA for 62eea7d

• Add specificity to light parent check

  alexchuber

  committed
  930663f

  Copy full SHA for 930663f

Commits on Nov 5, 2024

• comments

  alexchuber

  committed
  b72975e

  Copy full SHA for b72975e

• Ok, more comments

  alexchuber

  committed
  d8dab33

  Copy full SHA for d8dab33

Commits on Nov 12, 2024

• Merge pull request #1 from alexchuber/ext-lights

  Show description for bd4f274
  SergioRZMasson

  authored
  bd4f274

  Copy full SHA for bd4f274

• Added fix for camera roundtrip

  SergioRZMasson

  committed
  b67e087

  Copy full SHA for b67e087

Commits on Nov 13, 2024

• Fixed camera transformation based on parent

  SergioRZMasson

  committed
  2dc9a40

  Copy full SHA for 2dc9a40

• Added camera roundtrip tests

  SergioRZMasson

  committed
  1c2ff00

  Copy full SHA for 1c2ff00

• Added validation tests for camera transform

  SergioRZMasson

  committed
  7b8bfaf

  Copy full SHA for 7b8bfaf

• Make materialExporter public for extensions to use

  alexchuber

  committed
  710dd60

  Copy full SHA for 710dd60

• Make exportTextureAsync public (for now) for transmission

  alexchuber

  committed
  8d0029b

  Copy full SHA for 8d0029b

• Restore all material/texture extensions to previous working state

  alexchuber

  committed
  61831d1

  Copy full SHA for 61831d1

Commits on Nov 14, 2024

• Merge pull request #3 from alexchuber/uncomment-material-texture-extensions

  Show description for c44f379
  SergioRZMasson

  authored
  c44f379

  Copy full SHA for c44f379

• Added possible fix to round trip

  SergioRZMasson

  committed
  f3afff1

  Copy full SHA for f3afff1

• Merge branch 'sergio/new-gltf-exporter-2' into sergio/new-gltf-exporter-2-fix-camera

  SergioRZMasson

  committed
  665a298

  Copy full SHA for 665a298

Commits on Nov 18, 2024

• Fixed camera round trip

  SergioRZMasson

  committed
  6786e37

  Copy full SHA for 6786e37

• Fixed camera round trip

  SergioRZMasson

  committed
  79b23a4

  Copy full SHA for 79b23a4

• Finished camera work

  SergioRZMasson

  committed
  8149420

  Copy full SHA for 8149420

• Finished working on camera rotation

  SergioRZMasson

  committed
  7066164

  Copy full SHA for 7066164

• Removed unecessary transform

  SergioRZMasson

  committed
  df96f49

  Copy full SHA for df96f49

• Fixed transforms, added proper test for left handed scene

  SergioRZMasson

  committed
  4aed529

  Copy full SHA for 4aed529

• Small cleanup

  SergioRZMasson

  committed
  308c580

  Copy full SHA for 308c580

• Fixed tipos and removed comments

  SergioRZMasson

  committed
  0593ced

  Copy full SHA for 0593ced

• Merge pull request #5 from SergioRZMasson/sergio/new-gltf-exporter-2-fix-camera

  Show description for d512d55
  SergioRZMasson

  authored
  d512d55

  Copy full SHA for d512d55

• wip

  alexchuber

  committed
  8120e53

  Copy full SHA for 8120e53

• wip

  alexchuber

  committed
  50f3599

  Copy full SHA for 50f3599

Commits on Nov 19, 2024

• Clean up

  alexchuber

  committed
  2e31915

  Copy full SHA for 2e31915

• Added handle for linesMesh

  SergioRZMasson

  committed
  d06ffb3

  Copy full SHA for d06ffb3

• Added small change for fillMode when mesh is LinesMesh

  SergioRZMasson

  committed
  1a6d77a

  Copy full SHA for 1a6d77a

• Factor out common variables; extra comments

  alexchuber

  committed
  16a9918

  Copy full SHA for 16a9918

• Count stdMaterials, not just non-stdMaterials, since not sure what other materials like Multimaterial do

  alexchuber

  committed
  895f625

  Copy full SHA for 895f625

• Remove casting to Color3/4, use separate Color3/4 variables

  alexchuber

  committed
  6cf9810

  Copy full SHA for 6cf9810

• Remove int8 check, just need uint8

  alexchuber

  committed
  23625d6

  Copy full SHA for 23625d6

• remove unneeded comment

  alexchuber

  committed
  fe053d1

  Copy full SHA for fe053d1

• Added support for GPU instancing

  SergioRZMasson

  committed
  5384a0d

  Copy full SHA for 5384a0d

• Got hand rotation working

  SergioRZMasson

  committed
  826aeeb

  Copy full SHA for 826aeeb

• Merge branch 'sergio/new-gltf-exporter-2' into standard-material-vertex-colors

  alexchuber

  authored
  efe1d2f

  Copy full SHA for efe1d2f

Commits on Nov 20, 2024

• Pass "should serialize empty Babylon window.scene to glTF with only asset property" test

  alexchuber

  committed
  7cba726

  Copy full SHA for 7cba726

• nit: remove skipNode, instead early return null

  alexchuber

  committed
  ade6fcb

  Copy full SHA for ade6fcb

• Pass all animation-related tests

  alexchuber

  committed
  a52a871

  Copy full SHA for a52a871

• Pass all light-related tests

  alexchuber

  committed
  ed1deac

  Copy full SHA for ed1deac

• Update class and method names to pass metal-rough-related tests

  alexchuber

  committed
  4c35273

  Copy full SHA for 4c35273

Commits on Nov 21, 2024

• Merge pull request #7 from alexchuber/restore-integration-tests

  Show description for 2ed44f0
  SergioRZMasson

  authored
  2ed44f0

  Copy full SHA for 2ed44f0

• Merge pull request #6 from alexchuber/standard-material-vertex-colors

  Show description for 8398e5d
  SergioRZMasson

  authored
  8398e5d

  Copy full SHA for 8398e5d

• Add optional normalized to accessor factory

  alexchuber

  committed
  9a4655d

  Copy full SHA for 9a4655d

• Use normalized when creating most accessors

  alexchuber

  committed
  c32f748

  Copy full SHA for c32f748

• Add test to export instances pointing to same mesh

  alexchuber

  committed
  e04d827

  Copy full SHA for e04d827

• Merge pull request #9 from alexchuber/instance-test

  Show description for 6c2cd44
  SergioRZMasson

  authored
  6c2cd44

  Copy full SHA for 6c2cd44

• Merge pull request #8 from alexchuber/normalized-accessors

  Show description for 8ab7981
  SergioRZMasson

  authored
  8ab7981

  Copy full SHA for 8ab7981

• Removed old TODO

  SergioRZMasson

  committed
  fe0e516

  Copy full SHA for fe0e516

• Merge branch 'sergio/new-gltf-exporter-2' of https://github.com/SergioRZMasson/Babylon.js into sergio/new-gltf-exporter-2

  SergioRZMasson

  committed
  786ed2f

  Copy full SHA for 786ed2f

• Fixed bad importing

  SergioRZMasson

  committed
  5298bbd

  Copy full SHA for 5298bbd

• Fixed bad importing

  SergioRZMasson

  committed
  90a2a4d

  Copy full SHA for 90a2a4d

Commits on Nov 22, 2024

• Changed interators to be complient with UMD

  SergioRZMasson

  committed
  7b16084

  Copy full SHA for 7b16084

• Remove IMaterialExtension and its references

  alexchuber

  committed
  d2dc61d

  Copy full SHA for d2dc61d

• Merge pull request #10 from alexchuber/remove-stale-IMaterialExtension-references

  Show description for 435652e
  SergioRZMasson

  authored
  435652e

  Copy full SHA for 435652e

• Revert name change to copyFloatData

  alexchuber

  committed
  12094f8

  Copy full SHA for 12094f8

• Merge pull request #11 from alexchuber/revert-name-change

  Show description for 8eeaef8
  SergioRZMasson

  authored
  8eeaef8

  Copy full SHA for 8eeaef8

• Revert move of CopyFloatData import

  alexchuber

  committed
  e2fa453

  Copy full SHA for e2fa453

Commits on Nov 23, 2024

• Modify iwt and iwr in-place

  alexchuber

  committed
  f20b84b

  Copy full SHA for f20b84b

• Remove Nullable glTF object types from extension methods

  alexchuber

  committed
  ba0167b

  Copy full SHA for ba0167b

• Use PascalCase for exported module-level functions

  alexchuber

  committed
  6753129

  Copy full SHA for 6753129

• Remove unneeded normalize()

  alexchuber

  committed
  41cef91

  Copy full SHA for 41cef91

• Remove properties in-place in OmitDefaultValues

  alexchuber

  committed
  166c88a

  Copy full SHA for 166c88a

• Narrow types for DEFAULTS

  alexchuber

  committed
  84ac1cf

  Copy full SHA for 84ac1cf

Commits on Nov 25, 2024

• Remove commented-out functions

  alexchuber

  committed
  7ae5b78

  Copy full SHA for 7ae5b78

• Merge pull request #12 from alexchuber/first-pass-small-files-fixes

  Show description for 3c646b9
  SergioRZMasson

  authored
  3c646b9

  Copy full SHA for 3c646b9

• Update packages/dev/serializers/src/glTF/2.0/glTFMaterialExporter.ts

  Show description for 88c86ea
  

  SergioRZMasson

  and

  bghgary

  authored
  88c86ea

  Copy full SHA for 88c86ea

• Update packages/dev/serializers/src/glTF/2.0/glTFAnimation.ts

  Show description for ab14b32
  

  SergioRZMasson

  and

  bghgary

  authored
  ab14b32

  Copy full SHA for ab14b32

• Update packages/dev/serializers/src/glTF/2.0/glTFMorphTargetsUtilities.ts

  Show description for d37023e
  

  SergioRZMasson

  and

  bghgary

  authored
  d37023e

  Copy full SHA for d37023e

• Update packages/dev/serializers/src/glTF/2.0/glTFExporter.ts

  Show description for cd4da13
  

  SergioRZMasson

  and

  bghgary

  authored
  cd4da13

  Copy full SHA for cd4da13

• Changed GlTFMorphTarget to interface

  SergioRZMasson

  committed
  a63f7d9

  Copy full SHA for a63f7d9

• Merge branch 'sergio/new-gltf-exporter-2' of https://github.com/SergioRZMasson/Babylon.js into sergio/new-gltf-exporter-2

  SergioRZMasson

  committed
  90bae64

  Copy full SHA for 90bae64

• Fixed tipo

  SergioRZMasson

  committed
  fda7cf7

  Copy full SHA for fda7cf7

• Fixed comments on camera coordinates

  SergioRZMasson

  committed
  5be8cf2

  Copy full SHA for 5be8cf2

• Changed exporter to automatically detect need for 16bit integers

  SergioRZMasson

  committed
  f637d92

  Copy full SHA for f637d92

• Fixed error when using const

  SergioRZMasson

  committed
  a81af10

  Copy full SHA for a81af10

• Removed legacy comment

  SergioRZMasson

  committed
  a9ae8b2

  Copy full SHA for a9ae8b2

• Added test for morph target vertex buffers on WebGL1

  SergioRZMasson

  committed
  77e1369

  Copy full SHA for 77e1369

• Use PascalCase for non-exported module-level functions

  alexchuber

  committed
  a2edb8b

  Copy full SHA for a2edb8b

• Mark SolveMetallic as internal

  alexchuber

  committed
  20e52dc

  Copy full SHA for 20e52dc

• Update packages/dev/serializers/src/glTF/2.0/glTFExporter.ts

  Show description for e8a571a
  

  alexchuber

  and

  bghgary

  authored
  e8a571a

  Copy full SHA for e8a571a

• Capitalize L in IGlTFMorphTarget

  alexchuber

  committed
  d85014b

  Copy full SHA for d85014b

• Typo in solveApproxOne

  alexchuber

  committed
  d6b73fa

  Copy full SHA for d6b73fa

• Update packages/dev/core/src/Buffers/buffer.ts

  Show description for 698a56a
  

  alexchuber

  and

  bghgary

  authored
  698a56a

  Copy full SHA for 698a56a

• Update packages/dev/core/src/Buffers/buffer.ts

  Show description for d95787f
  

  alexchuber

  and

  bghgary

  authored
  d95787f

  Copy full SHA for d95787f

• Remove linter disables

  alexchuber

  committed
  cea0b7a

  Copy full SHA for cea0b7a

• Remove double comment

  alexchuber

  committed
  f73f79c

  Copy full SHA for f73f79c

• nits

  alexchuber

  committed
  3244640

  Copy full SHA for 3244640

• Rename IGLTFMorphTargets to IMorphTargetData

  alexchuber

  committed
  9a3e312

  Copy full SHA for 9a3e312

Commits on Nov 26, 2024

• Simplified vertex attribute check

  SergioRZMasson

  committed
  b31b744

  Copy full SHA for b31b744

• Merge branch 'sergio/new-gltf-exporter-2' of https://github.com/SergioRZMasson/Babylon.js into sergio/new-gltf-exporter-2

  SergioRZMasson

  committed
  3fb7fd9

  Copy full SHA for 3fb7fd9

Commits on Dec 3, 2024

• Update packages/dev/serializers/src/glTF/2.0/glTFUtilities.ts

  Show description for 185c939
  

  alexchuber

  and

  Popov72

  authored
  185c939

  Copy full SHA for 185c939

• Update packages/dev/serializers/src/glTF/2.0/glTFExporter.ts

  Show description for d4f016e
  

  SergioRZMasson

  and

  Popov72

  authored
  d4f016e

  Copy full SHA for d4f016e

• Update packages/dev/serializers/src/glTF/2.0/glTFExporter.ts

  Show description for a42ad44
  

  SergioRZMasson

  and

  Popov72

  authored
  a42ad44

  Copy full SHA for a42ad44

• Update packages/dev/serializers/src/glTF/2.0/glTFExporter.ts

  Show description for 9620f37
  

  SergioRZMasson

  and

  Popov72

  authored
  9620f37

  Copy full SHA for 9620f37

Commits on Dec 4, 2024

• Update packages/dev/serializers/src/glTF/2.0/glTFMorphTargetsUtilities.ts

  Show description for 493e193
  

  SergioRZMasson

  and

  ryantrem

  authored
  493e193

  Copy full SHA for 493e193

• Update packages/dev/serializers/src/glTF/2.0/glTFMorphTargetsUtilities.ts

  Show description for 45ad7b6
  

  SergioRZMasson

  and

  ryantrem

  authored
  45ad7b6

  Copy full SHA for 45ad7b6

• Update packages/dev/serializers/src/glTF/2.0/dataWriter.ts

  Show description for 14238d3
  

  SergioRZMasson

  and

  ryantrem

  authored
  14238d3

  Copy full SHA for 14238d3

• Update packages/dev/serializers/src/glTF/2.0/glTFMaterialExporter.ts

  Show description for e13dce7
  

  SergioRZMasson

  and

  ryantrem

  authored
  e13dce7

  Copy full SHA for e13dce7

• Update packages/dev/serializers/src/glTF/2.0/glTFMaterialExporter.ts

  Show description for fd0a047
  

  SergioRZMasson

  and

  ryantrem

  authored
  fd0a047

  Copy full SHA for fd0a047

• Moved explicit property to constructor

  SergioRZMasson

  committed
  cc390ca

  Copy full SHA for cc390ca

• Fixed wrong capitalization

  SergioRZMasson

  committed
  317ec18

  Copy full SHA for 317ec18

• Simplified morph targets min max ranges

  SergioRZMasson

  committed
  473e5eb

  Copy full SHA for 473e5eb

• Added proper error handling when extracting morph target data

  SergioRZMasson

  committed
  818b9ad

  Copy full SHA for 818b9ad

• Changed light normalization to not modify original babylon object

  SergioRZMasson

  committed
  bb073db

  Copy full SHA for bb073db

• Reverted change made to _byteOffset

  SergioRZMasson

  committed
  763558f

  Copy full SHA for 763558f

• Fixed type mismatch in GPU instancing accessor creation

  SergioRZMasson

  committed
  9d18d31

  Copy full SHA for 9d18d31

• Removed duplicated functions

  SergioRZMasson

  committed
  7d82ce4

  Copy full SHA for 7d82ce4

• Removed double assignment

  SergioRZMasson

  committed
  ef46680

  Copy full SHA for ef46680

• Changed default value compare to be done using equalsWithEpsilon

  SergioRZMasson

  committed
  758e20c

  Copy full SHA for 758e20c

• Updating naming convention for public function

  SergioRZMasson

  committed
  f333f54

  Copy full SHA for f333f54

• Fixed index buffer flipping logic

  SergioRZMasson

  committed
  f765226

  Copy full SHA for f765226

• Added code to avoid allocations during processing

  SergioRZMasson

  committed
  a1f989e

  Copy full SHA for a1f989e