Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Load boundingInfo when use KHR_draco_mesh_compression #15882

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

Starryi
Copy link
Contributor

@Starryi Starryi commented Nov 23, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 23, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 23, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 23, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 23, 2024

Copy link
Contributor

@alexchuber alexchuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well lets wait on @bghgary final approval

Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing, but LGTM otherwise.

packages/dev/loaders/src/glTF/2.0/glTFLoader.ts Outdated Show resolved Hide resolved
@sebavan sebavan merged commit d54279a into BabylonJS:master Nov 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants