Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSAA render targets: Resolve the depth texture (if any) and allow for manual resolve #15888

Merged
merged 7 commits into from
Nov 26, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Nov 25, 2024

Note that this is not yet implemented in WebGPU (it's a little more difficult than in WebGL, where ANGLE supports depth texture resolve, which you have to do manually in WebGPU).

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@sebavan
Copy link
Member

sebavan commented Nov 25, 2024

Last check would be to be sure Native is still all good

@Popov72
Copy link
Contributor Author

Popov72 commented Nov 25, 2024

Last check would be to be sure Native is still all good

cc @bghgary I guess?

@sebavan sebavan merged commit 8ab1527 into BabylonJS:master Nov 26, 2024
12 checks passed
@bghgary
Copy link
Contributor

bghgary commented Nov 26, 2024

Last check would be to be sure Native is still all good

cc @bghgary I guess?

Native doesn't support MSAA in render targets yet, so there is nothing to test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants