Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparation for playground snapshots and testing #15889

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Nov 25, 2024

This PG does the following:

  1. restructure the playwright configuration and test detection. From now on any test file throughout the repository matched by the specific playwright project matcher will be included in the tests of this specific project.
  2. Added playground test project as a preparation for playground user interaction testing
  3. Prepare the playground to a full snapshot deployment and testing.

The next steps (after this is merged) are:

  1. Build the playground as part of the standard CI
  2. Deploy this to a snapshot directory so we can test the actual playground (and not only the default playground with CDN snapshots)
  3. Run the playground tests as part of this CI step. Fail if the playground doesn't work correctly.

Note that I opted-out of snapshot testing for the actual website. Mainly because of different rendering cross OSes AND the fact that we have a constant version changing, which will require either not rendering this part or ignoring a lot of pixel changes, which will render snapshot testing useless.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW requested a review from deltakosh November 25, 2024 18:43
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Reviewer - this PR has made changes to one or more package.json files.

@BabylonJS BabylonJS deleted a comment from bjsplat Nov 25, 2024
@BabylonJS BabylonJS deleted a comment from bjsplat Nov 25, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Reviewer - this PR has made changes to one or more package.json files.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure the webgpu.json file should be removed

@RaananW
Copy link
Member Author

RaananW commented Nov 25, 2024

not sure the webgpu.json file should be removed

AFAIK this file has been merged with config.json and has not been used in a long time, at least not in the CI. I can of course revert it, if it is still being used.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Reviewer - this PR has made changes to one or more package.json files.

@sebavan
Copy link
Member

sebavan commented Nov 25, 2024

not sure the webgpu.json file should be removed

AFAIK this file has been merged with config.json and has not been used in a long time, at least not in the CI. I can of course revert it, if it is still being used.

Also I am not sure to understand how the webgl2 and webgpu tests are now able to run (it is clearly Monday :-) ) ?

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Reviewer - this PR has made changes to one or more package.json files.

@RaananW
Copy link
Member Author

RaananW commented Nov 25, 2024

Also I am not sure to understand how the webgl2 and webgpu tests are now able to run (it is clearly Monday :-) ) ?

Just as they were running until now! Playwright only. We don't use jest anymore. there are many different ways starting them. The issue with the CI was actually browserstack (which is only enabled on the CI).

To start the tests you can:

  1. use the vscode extension
  2. Use npm run test:visualization
  3. Open the UI using npm run test:visualization:ui
  4. run the tests directly using playwright npx playwright test --project-webgl2

Jest and puppeteer as visualization testing was deprecated a long time ago. we don't use on the CI (except fro webgl1) and i don't recommend using it locally as well. Playwright is better.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

@RaananW
Copy link
Member Author

RaananW commented Nov 25, 2024

I'll fix the build. This is a permission issue.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@RaananW RaananW merged commit 6dfbc0e into BabylonJS:master Nov 27, 2024
12 checks passed
@RaananW RaananW deleted the testsReogAndToolsTesting branch November 27, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants