-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation for playground snapshots and testing #15889
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15889/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15889/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15889/merge#BCU1XR#0 |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Reviewer - this PR has made changes to one or more package.json files. |
Reviewer - this PR has made changes to one or more package.json files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure the webgpu.json file should be removed
AFAIK this file has been merged with config.json and has not been used in a long time, at least not in the CI. I can of course revert it, if it is still being used. |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
Reviewer - this PR has made changes to one or more package.json files. |
Also I am not sure to understand how the webgl2 and webgpu tests are now able to run (it is clearly Monday :-) ) ? |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Reviewer - this PR has made changes to one or more package.json files. |
Just as they were running until now! Playwright only. We don't use jest anymore. there are many different ways starting them. The issue with the CI was actually browserstack (which is only enabled on the CI). To start the tests you can:
Jest and puppeteer as visualization testing was deprecated a long time ago. we don't use on the CI (except fro webgl1) and i don't recommend using it locally as well. Playwright is better. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
I'll fix the build. This is a permission issue. |
Reviewer - this PR has made changes to one or more package.json files. |
WebGL2 visualization test reporter: |
Visualization tests for WebGPU (Experimental) |
Reviewer - this PR has made changes to one or more package.json files. |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
Reviewer - this PR has made changes to one or more package.json files. |
Visualization tests for WebGPU (Experimental) |
WebGL2 visualization test reporter: |
This PG does the following:
The next steps (after this is merged) are:
Note that I opted-out of snapshot testing for the actual website. Mainly because of different rendering cross OSes AND the fact that we have a constant version changing, which will require either not rendering this part or ignoring a lot of pixel changes, which will render snapshot testing useless.