Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V8 performance hack fix #15892

Merged
merged 2 commits into from
Nov 26, 2024
Merged

V8 performance hack fix #15892

merged 2 commits into from
Nov 26, 2024

Conversation

deltakosh
Copy link
Contributor

No description provided.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color as well ?

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 25, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 26, 2024

@rapid-images-tore-levenstam
Copy link
Contributor

This is... something :D How did you come up with this, do you have any source information you could link?

@deltakosh
Copy link
Contributor Author

We got help from the Edge engineers working on the v8 engine:)

@deltakosh deltakosh merged commit d932807 into master Nov 26, 2024
12 checks passed
@deltakosh deltakosh deleted the v8-update branch November 26, 2024 14:38
@sebavan
Copy link
Member

sebavan commented Nov 26, 2024

@rapid-images-tore-levenstam https://issues.chromium.org/issues/380433753 :-) the dev team was amazing in helping us.

@Jeggery
Copy link

Jeggery commented Nov 27, 2024

We got help from the Edge engineers working on the v8 engine:)

I didn't see any referenced places in V_8Performance Hack, Will it be used in the future?

@deltakosh
Copy link
Contributor Author

Nope it only needs to be here to prevent v8 to deoptimize the class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants