Fix audio engine init issue #15922
Fix audio engine init issue #15922
Conversation
When the `Engine` constructor is called with a `WebGLRenderingContext` or `WebGL2RenderingContext`, the audio engine does not get initialized. This change fixes the issue by calling `Engine._sharedInit` with the WebGL rendering context's canvas. Note that the WebGL rendering context's canvas may be an `OffscreenCanvas` and its type is cast to `HTMLCanvasElement` for the call to `Engine._sharedInit` because it would be a large change to make `AbstractEngine.__renderingCanvas` support both types. This is done the same way in the `WebGPUEngine` constructor, with the only consequence for the audio engine being that the mute button stays at the top-left of the document instead of automatically repositioning to the top-left of the canvas.
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15922/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15922/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15922/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
|
I wonder if instead we could change a tiny bit how it is done ? In thinEngine, lets remove the canvas assignement in the constructor: And called sharedInit instead: Then in Engine we should be able to remove the _sharedInit call: As well as in WebGPUEngine: I guess this should ensure that _sharedInit would be call consistently ? |
I don't think this will work because |
|
I think we can do both:
|
When the
Engineconstructor is called with aWebGLRenderingContextorWebGL2RenderingContext, the audio engine does not get initialized. This change fixes the issue by callingEngine._sharedInitwith the WebGL rendering context's canvas.Note that the WebGL rendering context's canvas may be an
OffscreenCanvasand its type is cast toHTMLCanvasElementfor the call toEngine._sharedInitbecause it would be a large change to makeAbstractEngine._renderingCanvassupport both types. This is done the same way in theWebGPUEngineconstructor, with the only consequence for the audio engine being that the mute button stays at the top-left of the document instead of automatically repositioning to the top-left of the canvas.