Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(virtualjoystick): also handle pointercancel events #15925

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

pjoe
Copy link
Contributor

@pjoe pjoe commented Dec 3, 2024

Also handles pointercancel event for virtual joysticks, should fix issues with joysticks getting stuck on e.g. iPad when app focus is lost, when for example swiping to switch between apps.

See also: https://developer.mozilla.org/en-US/docs/Web/API/Element/pointercancel_event

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 3, 2024

@sebavan
Copy link
Member

sebavan commented Dec 3, 2024

cc @AmoebaChant to check if we also use it on the other inputs

@sebavan sebavan merged commit a87b232 into BabylonJS:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants