Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FrameGraph: add support for shadow generators (CSM included) #15962

Merged
merged 26 commits into from
Dec 10, 2024
Merged

FrameGraph: add support for shadow generators (CSM included) #15962

merged 26 commits into from
Dec 10, 2024

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Dec 6, 2024

Test PG for shadows: https://playground.babylonjs.com/#FTAT6U#11

Also in this PR:

  • ResourceContainer block added
  • Default render graph when you browse https://nrge.babylonjs.com/ updated
  • I added some new input types (storage texture, resource container, shadow generator, shadow light, storage buffer), but didn't assign colors to them (black at the time) => TODO

Popov72 added 24 commits November 22, 2024 15:10
@Popov72
Refactor to use InternalTexture instead of RenderTargetWrapper
2e3b9d6
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
5d8adf9 
… framegraph-internaltexture-refactor
@Popov72
Add missing "readonly" and docs
013484f
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
f83079e 
… framegraph-internaltexture-refactor
@Popov72
Address comments
36e4fdc
@Popov72
Fix default value for depth texture format
64a3715
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
2876218 
… framegraph-internaltexture-refactor
@Popov72
Fix getter returning undefined
9e28a1f
@Popov72
Add resouce container and shadow generator task
046a0fe
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
d24d16e 
… framegraph-resourcecont-shadowgen
@Popov72
Calculate a suitable light position for better shadows
11a5564
@Popov72
Add editable properties to shadow generator
a0f613a
@Popov72
Use a dummy light for ShadowLight when necessary
1481a2e
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
bd74795 
… framegraph-resourcecont-shadowgen
@Popov72
Fix framebuffer not reset to the right one after MSAA resolve
4da574c
@Popov72
Set a better default graph
a67c225
@Popov72
Factor and simplify code
835093d
@Popov72
Finish implementation of the shadow generator block and task
fc2e46d
@Popov72
Add the cascaded shadow generator task and block
d37a270
@Popov72
Merge branch 'master' of https://github.com/BabylonJS/Babylon.js into…
ed634f9 
… framegraph-resourcecont-shadowgen
@Popov72
Fix properties of object renderer not saved
9b9ce6a
@Popov72
Fix crash when effectWrapper / effect not built
0561217
@Popov72
Remove wrong code
6e5a402
@Popov72
Fix typos
2b3c32e
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 6, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 6, 2024

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 6, 2024

Snapshot stored with reference name:
refs/pull/15962/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15962/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15962/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/15962/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/15962/merge
https://gui.babylonjs.com/?snapshot=refs/pull/15962/merge
https://nme.babylonjs.com/?snapshot=refs/pull/15962/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/15962/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 6, 2024

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15962/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 6, 2024

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15962/merge/testResults/webgl2playwright/index.html

sebavan
sebavan reviewed Dec 6, 2024
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if possible but the nullable camera seems to complexify the code. should we not have a dummy one ? and do we render without one ?

packages/dev/core/src/Lights/directionalLight.ts Outdated Show resolved Hide resolved
packages/dev/core/src/scene.ts Show resolved Hide resolved
packages/dev/core/src/PostProcesses/postProcess.ts Show resolved Hide resolved
packages/dev/core/src/Materials/Textures/renderTargetTexture.ts Outdated Show resolved Hide resolved
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 7, 2024

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/guiEditor/

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 9, 2024

You have made possible changes to one or more graph tools. To test the snapshots:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeGeometryEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/nodeRenderGraphEditor/
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/TOOLS/refs/pull/15962/merge/guiEditor/

@sebavan sebavan merged commit 49ead34 into BabylonJS:master Dec 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
frame graph new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Popov72 @bjsplat @sebavan