Adding normalization to realtime irradiance filtering #15963
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/dev/core/src/Rendering/IBLShadows/iblShadowsVoxelTracingPass.ts
Outdated
Show resolved
Hide resolved
packages/dev/core/src/Shaders/ShadersInclude/hdrFilteringFunctions.fx
Outdated
Show resolved
Hide resolved
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
MiiBond
force-pushed
the
mbond/cdf-importance-sampling-pdf-fix
branch
from
f906525 to
db17274
Compare
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15963/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15963/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15963/merge#BCU1XR#0 |
|
Visualization tests for WebGPU (Experimental) |
|
WebGL2 visualization test reporter: |
|
Hi @MiiBond , was just wondering if it is a CI issue or are these tests also failing locally? From this result - https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15963/merge/testResults/webgpuplaywright/index.html#?testId=3a254ccdc8803e849057-00e67dbdb176b7700210 , it seems like a shader issue? If it works locally but not on the CI please let me know so I can investigate. |
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
3 similar comments
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
…ingPass.ts Co-authored-by: Popov72 <github@evpopov.com>
MiiBond
force-pushed
the
mbond/cdf-importance-sampling-pdf-fix
branch
from
dfa5b7f to
e77b8ac
Compare
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
|
Okay, I think this is good to merge? |
Big improvement to importance sampling irradiance using CDF. Previously, we weren't applying the PDF properly to each sample.
Now, the results of real-time irradiance are very close to raytraced ground truth.