Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgbdEncoder is needed in a different place #15992

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Dec 12, 2024

This fixes an issue when trying to run the EncodeTextureToRGBD function before ever calling ExpandRGBDTexture. The shader initialization is now in the right place for both.

A small improvement in error handling as well, adding an actual error to _retryWithInterval.

@RaananW RaananW marked this pull request as ready for review December 12, 2024 11:53
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW enabled auto-merge (squash) December 12, 2024 11:59
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15992/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@RaananW RaananW requested a review from deltakosh December 12, 2024 12:29
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15992/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15992/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit 8aa9022 into BabylonJS:master Dec 12, 2024
12 of 14 checks passed
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15992/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW deleted the fixRgbdEncoderPlacement branch December 12, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants