Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XR's near interaction's selection mesh positioning #15993

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Dec 12, 2024

The temp vectors were being used by other functions, which changed the tmpVector's value.
Also added a new flag to hide the selection mesh even if it should be visible.

@RaananW RaananW added the bug label Dec 12, 2024
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@RaananW RaananW marked this pull request as ready for review December 12, 2024 16:27
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15993/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

@RaananW RaananW enabled auto-merge (squash) December 12, 2024 20:25
@bjsplat
Copy link
Collaborator

bjsplat commented Dec 12, 2024

Visualization tests for WebGL 1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15993/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit 99500ab into BabylonJS:master Dec 12, 2024
12 of 14 checks passed
@RaananW RaananW deleted the fixNearInteraction branch December 13, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants