Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More common shader constants and helpers for helperFunctions.fx #16011

Merged
merged 6 commits into from
Dec 18, 2024
Merged

More common shader constants and helpers for helperFunctions.fx #16011

merged 6 commits into from
Dec 18, 2024

Conversation

kircher1
Copy link
Contributor

No description provided.

@kircher1
Copy link
Contributor Author

Let me know if there is a similar place in WGSL that I should add these new constants/functions for parity.

@sebavan
Copy link
Member

sebavan commented Dec 17, 2024

ShadersWGSL is an equivalent of the folder Shaders so same place same name there would do :-)

sebavan
sebavan reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be perfect with the equivalent wglsl

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 18, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 18, 2024

Snapshot stored with reference name:
refs/pull/16011/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16011/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16011/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16011/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16011/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16011/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16011/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16011/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 18, 2024

Visualization tests for WebGPU (Experimental)

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16011/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Dec 18, 2024

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16011/merge/testResults/webgl2playwright/index.html

@sebavan sebavan merged commit dd81261 into BabylonJS:master Dec 18, 2024
14 checks passed
MiiBond pushed a commit to MiiBond/Babylon.js that referenced this pull request Dec 20, 2024
@kircher1
More common shader constants and helpers for helperFunctions.fx (Baby…
38aca34 
…lonJS#16011)

* More common constants and helpers for helperFunctions.fx

* wip

* resolve

* fix wgsl saturate call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebavan sebavan sebavan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kircher1 @sebavan @bjsplat