-
Notifications
You must be signed in to change notification settings - Fork 3.6k
glTF export: Fix submesh indices handling #17204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/17204/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/17204/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/17204/merge#BCU1XR#0 |
Devhost visualization test reporter: |
Visualization tests for WebGPU |
WebGL2 visualization test reporter: |
LGTM but prefer to wait on @bghgary review :-) |
Thanks for the quick work on this issue! Any idea when this might make it into a release? My team is locked into our current version until we can get one with this issue resolved. |
From https://forum.babylonjs.com/t/multi-materials-cause-strange-glb-export-artifacts/60558.
Fixes bug with submeshes where indexStart was improperly handled when creating the buffer view.
While in the area, I did some contained refactoring. The main points are:
offset
parameter. I think this was a remnant from before the rework last year, as I couldn't tell what it would've been used for.