Skip to content

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Sep 26, 2025

From https://forum.babylonjs.com/t/multi-materials-cause-strange-glb-export-artifacts/60558.
Fixes bug with submeshes where indexStart was improperly handled when creating the buffer view.
While in the area, I did some contained refactoring. The main points are:

  • No more offset parameter. I think this was a remnant from before the rework last year, as I couldn't tell what it would've been used for.
  • As little copying as possible, which also means subsetting ahead of time.
  • Miscellaneous clean up

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2025

@deltakosh deltakosh requested a review from bghgary September 29, 2025 14:37
@sebavan
Copy link
Member

sebavan commented Sep 29, 2025

LGTM but prefer to wait on @bghgary review :-)

@clevengermatt
Copy link

Thanks for the quick work on this issue! Any idea when this might make it into a release? My team is locked into our current version until we can get one with this issue resolved.

@alexchuber alexchuber marked this pull request as draft October 6, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants