Skip to content

Conversation

alexchuber
Copy link
Contributor

@alexchuber alexchuber commented Oct 3, 2025

From https://forum.babylonjs.com/t/broken-textures-after-glb-export/60756.

Changes:

  • Add epsilon check to prevent division by 0
  • Use new Color3 for maxBaseColor to avoid modifying the reference value Black
    • Make all reference values deeply immutable to prevent this in future
  • Nit: remove dead code nearby

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 3, 2025

@deltakosh deltakosh requested a review from Popov72 October 6, 2025 15:56
@alexchuber alexchuber merged commit 1db8e98 into BabylonJS:master Oct 6, 2025
20 checks passed
@alexchuber alexchuber deleted the fix-spec-gloss-conversion-export branch October 6, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants