Skip to content

Conversation

georginahalpern
Copy link
Contributor

@georginahalpern georginahalpern commented Oct 4, 2025

  • Fix hex input which was showing as invalid for color4
  • Update colorPicker based on design mockup (my most recent pass messed up the styling of the picker)
  • Add displayName to shared components for easier react debugging

Still have more styling to do but it fixes the broken state and gets us closer to UX mockup
image

For reference this is the ux mockup
image

and this is current UX after last CSS changes :D broken!
image

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

@georginahalpern georginahalpern enabled auto-merge (squash) October 4, 2025 01:15
@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

You have changed file(s) that made possible changes to the sandbox.
You can test the sandbox snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/SANDBOX/refs/pull/17238/merge/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

Building or testing the playground has failed.

If the tests failed, results can be found here:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17238/merge/testResults/

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 4, 2025

You have made possible changes to the playground.
You can test the snapshot here:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17238/merge/

The snapshot playground with the CDN snapshot (only when available):

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/PLAYGROUND/refs/pull/17238/merge/?snapshot=refs/pull/17238/merge

Note that neither Babylon scenes nor textures are uploaded to the snapshot directory, so some playgrounds won't work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants