-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing GUI Editor into Master #9609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add color picker
Create properties for slider and add slider entry in the left panel
deltakosh
reviewed
Jan 4, 2021
deltakosh
reviewed
Jan 4, 2021
guiEditor/src/components/propertyTab/properties/floatPropertyTabComponent.tsx
Outdated
Show resolved
Hide resolved
deltakosh
reviewed
Jan 4, 2021
deltakosh
reviewed
Jan 4, 2021
deltakosh
reviewed
Jan 4, 2021
Popov72
reviewed
Jan 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few comments from me.
guiEditor/src/diagram/properties/sliderGuiPropertyComponent.tsx
Outdated
Show resolved
Hide resolved
@Popov72 love these name suggestions! Going to change them now. |
All good for me! |
congrats! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GUI Editor will be new tool to allow users to create and modify GUI for scenes. It will be a standalone editor similar to NME. This is the foundation PR to officially merge the beginning working codebase into master. This is not a finished editor.
The GUI editor was created by using the code base of NME, removing the node material specific code, and then adding specific features for the gui editor. While I tried my best to remove most of the node material related code please let me know if there is any extra remaining.
Current features:
Important Files: These are the files with the most work done.
TODOs:
You will see various places in the code with marked TODOs for future work.
Property tab component is incomplete and has several chunks commented. To be implemented later this week.
Includes property grid components that will be removed once the shared UI work is complete.
Additional comments need to added.
Thank you in advance for your time! :)