Push camera dimensions back to NativeVideo texture #1121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-MSFT
requested review from
CedricGuillemet,
ryantrem,
bghgary,
CoPrez and
docEdub
CoPrez
approved these changes
Aug 23, 2022
ryantrem
reviewed
Aug 23, 2022
ryantrem
reviewed
Aug 23, 2022
|
Dang we have too much duplication between the different NativeCameraImpls. I don't think each platform should re-define the header. We can fix this in a later change, but if we find ourselves continuing to duplicate things across platforms in future changes, we should consider reworking this a bit. |
ryantrem
reviewed
Aug 23, 2022
ryantrem
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pushes the actual used camera dimension back to the NativeVideo texture so that readPixels and getSize return the proper dimensions of the object rather than defaulting to whatever is passed in for maxHeight and maxWidth as outlined in #1107. With this change we will properly report the correct resolution on both iOS and Android. Android requires additional follow up work to select the correct camera configuration to most closely match the target resolution.