Android native camera resolution and orientation #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
Alex-MSFT
reviewed
Aug 25, 2022
ryantrem
reviewed
Aug 25, 2022
Co-authored-by: Alex Tran <altran@microsoft.com>
ryantrem
approved these changes
Aug 26, 2022
Co-authored-by: Ryan Tremblay <ryantrem@msn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses the android NativeCamera plugin implementation so that it picks a camera resolution based on the passed in maxWidth and maxHeight. Additionally this change fixes the rotation and orientation of the returned camera texture. More information about those two issues can be found in issue #1107.