Fix framebuffer texture capture with texStorage2D bug #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Dec 20, 2023
|
@06wj Thanks a lot !!! I had this a couple days back while debugging and it is deadly annoying !!! |
sebavan
approved these changes
Dec 20, 2023
sebavan
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Test demo: https://06wj.github.io/test/spectorJSTest/
The picture below is the capture result.The framebuffer display a blank picture.
Solution
When using texStorage2D, there is no type value in the texture customData.
Because there is no type value in customData, textureType will be set to null, causing an error when readPixels is called, leading to a capture failure.
So a change has been made here. When there is no type, the framebuffer's attachmentComponentType is still used.
The picture below is the fixed capture result.