Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pluggy 1.0.0 #249

Closed
The-Compiler opened this issue Sep 13, 2021 · 1 comment · Fixed by #250
Closed

Allow pluggy 1.0.0 #249

The-Compiler opened this issue Sep 13, 2021 · 1 comment · Fixed by #250

Comments

@The-Compiler
Copy link

Recently, pluggy 1.0.0 was released, but diff_cover depends on ^0.13.1, i.e. < 1.0.0.

There were relatively few backwards-incompatible changes, so I'd expect it to (hopefully) be a drop-in replacement, like it was e.g. for pytest: pytest-dev/pytest#9040
The-Compiler added a commit to qutebrowser/qutebrowser that referenced this issue Sep 13, 2021
@The-Compiler
requirements: Use older pluggy
41febf9 
See Bachmann1234/diff_cover#249
@kasium kasium mentioned this issue Sep 13, 2021
Merged
@kasium
Copy link
Contributor

kasium commented Sep 13, 2021

Thanks for the heads up. I opened a PR and waiting for @Bachmann1234 for approval/feedback

mkonig pushed a commit to mkonig/qutebrowser that referenced this issue Dec 7, 2021
@The-Compiler
requirements: Use older pluggy
0dfd0d1 
See Bachmann1234/diff_cover#249
twigleingrid pushed a commit to twigleingrid/qutebrowser that referenced this issue May 13, 2022
@The-Compiler @twigleingrid
requirements: Use older pluggy
690394e 
See Bachmann1234/diff_cover#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for pluggy 1.0 kasium/diff_cover
2 participants
@The-Compiler @kasium