Normalise LCOV source paths #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Under windows, the git paths use unix-style paths, while the lcov paths use windows-style paths. In addition, coverage.py uses relative paths, but other tools like llvm-cov report absolute paths. So the source paths need to be made relative and unix-style.
|
Thanks for the fix. assuming the build passes I should be able to get this out this weekend |
|
I did not end up getting to this.et me merge it now and I'll release it soon. Than you for the pr! |
|
@matsjoyce-refeyn https://pypi.org/project/diff-cover/8.0.1/ is out! Thanks again |
|
@Bachmann1234 Thank you! That was a very fast release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under windows, the git paths use unix-style paths, while the lcov paths use windows-style paths. In addition, coverage.py uses relative paths, but other tools like llvm-cov report absolute paths. So the source paths need to be made relative and unix-style.
I've tested this on Windows, before this fix I get
No lines with coverage information in this diff.while afterwards the tool reports coverage changes correctly.