#378 Get a nice error message when running diff-quality with a tool which is not installed #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dperl-dls
force-pushed
the
378_fix_error_message
branch
from
a0b744a
to
59fed0c
Compare
Black is upset, looks like the change is simple enough
|
ok, quick glance looks like some tests broke. My guess is its some mocking that broke. Let me know if you need some help looking a bit deeper |
|
Also, hope you dont mind my commit, I just wanted to get past the formatting step |
|
Oh, my bad. It was because |
|
Alright, lets get this out. Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #378
To test, compare with "steps to reproduce" in the linked issue