#412 Add path validation in untracked files processing #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've implemented a function _get_file_lines that emulates the behavior of self._git_diff(), which returns an empty list for binary files. Additionally, the function _validate_path_to_diff leverages the basic path validation mechanisms used in self._git_diff() to ensure consistency. |
|
This is looking alright. Can you add a test and make sure to run isort and black? |
MihailPereverza
force-pushed
the
412_fix_path_validation
branch
from
85dd725
to
cf9d984
Compare
|
Yes, it's ready. I have added the tests and ran the linters using the script |
|
Alright, lets get this out there. Thanks for the PR! |
|
Released https://pypi.org/project/diff-cover/9.1.1/ Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #412