Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In b2sdk-2.4.0, some files are uploaded redundantly #502

Closed
titus8 opened this issue Jun 19, 2024 · 4 comments
Closed

In b2sdk-2.4.0, some files are uploaded redundantly #502

titus8 opened this issue Jun 19, 2024 · 4 comments

Comments

@titus8
Copy link

titus8 commented Jun 19, 2024

Good day.

I've discovered a curious issue in b2sdk-2.4.0 that is a regression from b2sdk-2.3.0.

When uploading the tree

    test
    |
    |---- a
    |       |---- foo (a file)
    |
    |---- "a b"
    |       |---- bar (a file)

the first time, foo and bar are uploaded as expected. Subsequent uploads will always upload bar, even if the mod time is unchanged. If the directory a is removed, the redundant uploads of bar do not occur.

I've attached a script to reproduce this issue. in issue.py, you will need to set the destination bucket and path appropriately.

I'm using Python 3.12 on a Mac M1 running macOS Sonoma 14.5. I've attached a minimum repro script.

Thanks.

b2sdk-2.4.0-issue.tgz

@titus8
Copy link
Author

titus8 commented Jun 19, 2024

Here's another example:

  test
  |
  |---- a
  |     |---- foo (a file)
  |
  |---- a.b (a file)

a.b updates unnecessarily.

@mjurbanski-reef
Copy link
Contributor

Regression happened in #501 . We expected slight change in synchronization order, but apparently there is was a much more serious side effect that was not detected by tests.

Both regression and tests coverage will be fixed ASAP.
Thank you for nicely described bug report :)

mjurbanski-reef added a commit to reef-technologies/b2-sdk-python that referenced this issue Jun 19, 2024
@mjurbanski-reef
Copy link
Contributor

@titus8
Copy link
Author

titus8 commented Jun 19, 2024

Verified. Outstanding, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants