use xdg compliant path for config #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuchan-reef
force-pushed
the
yed/cli958-xdg-compliant-config-path
branch
4 times, most recently
from
401ae83 to
0471968
Compare
jsuchan-reef
force-pushed
the
yed/cli958-xdg-compliant-config-path
branch
from
44802be to
c4672b7
Compare
jsuchan-reef
commented
Nov 24, 2023
mjurbanski-reef
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing b2 should respect the spec's default fallback for
XDG_CONFIG_HOMEB2_Command_Line_Tool#958to avoid making this a breaking change and ignoring existing config file in non-XDG path, there's a new step of checking for given file before checking XDG path. That makes the logic more consistent for both scenarios when
profileis provided and when it's not.the same change in docstring needs to be done in B2 CLI repo, but let's validate the approach here first before duplicating the work.