-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove queue specific options #304
base: master
Are you sure you want to change the base?
Conversation
LGTM, likely will be a major release? cc @rwjblue / @krisselden |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but I'd like to wait for a bit on landing this.
Ember has committed to ensuring that the ember-2-legacy
addon will provide all Ember 2.x APIs through Ember 3.4 (as a way to extend the time apps have to migrate off of Ember 2.x APIs a bit). If we land this now and release a major version bump, we will be forced to maintain two versions for a few months.
@rwjblue should we fork a 2-release branch for 2x stuff? Or hold off for a-bit first. |
There are some larger things in the works that I'd like to land for current Ember versions, and having to maintain both branches will be somewhat annoying... Maybe we can keep |
826acf0
to
beabee1
Compare
beabee1
to
cc1d212
Compare
rebased in case |
@rwjblue maybe we can merge this ? since |
as mentioned here emberjs/ember.js#16097