Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove queue specific options #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Jan 11, 2018

as mentioned here emberjs/ember.js#16097

@stefanpenner
Copy link
Collaborator

LGTM, likely will be a major release?

cc @rwjblue / @krisselden

Copy link
Collaborator

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I'd like to wait for a bit on landing this.

Ember has committed to ensuring that the ember-2-legacy addon will provide all Ember 2.x APIs through Ember 3.4 (as a way to extend the time apps have to migrate off of Ember 2.x APIs a bit). If we land this now and release a major version bump, we will be forced to maintain two versions for a few months.

@stefanpenner
Copy link
Collaborator

@rwjblue should we fork a 2-release branch for 2x stuff? Or hold off for a-bit first.

@rwjblue
Copy link
Collaborator

rwjblue commented Jan 11, 2018

There are some larger things in the works that I'd like to land for current Ember versions, and having to maintain both branches will be somewhat annoying...

Maybe we can keep master as 2.x and make a next branch where we can target further cleanup that can be used in Ember after 3.4?

@bekzod
Copy link
Contributor Author

bekzod commented Mar 23, 2019

rebased in case

@bekzod
Copy link
Contributor Author

bekzod commented Oct 2, 2019

@rwjblue maybe we can merge this ? since before after no longer used in ember

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants