Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: badger governance progression #1557

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

sajanrajdev
Copy link
Collaborator

@sajanrajdev sajanrajdev commented Aug 9, 2024

Audit scripts

  • Introduces a script to audit the following permissions on all of Badger's vaults, strategies, controllers and general infrastructure: governance, strategist, guardian, owner, admin
  • Introduced the script to audit the proxy admin of all of the same contracts from above

Both scripts print out and store their reports on CSVs. The current snapshot of the audit is pushed along these changes.

In addition, the acl_audit script, previously developed can be used to audit the acl permissions over the few relevant contracts. This can be found here: /home/sajan/badger/badger-multisig/scripts/badger/acl_manager.py

Dev Multisig Progression Script

Introduces a series of scripts to do the following:

  • Step1.1: Grant DEFAULT_ADMIN_ROLE to TechOps on legacy ACL contracts
  • Step1.2: Transfer governance to the Governance Timelock on all vaults and controllers that were not already governed by this contract
  • Step2: Changes the signers within the Dev Multisig for the Treasury Vault, Badger TechOps, Community Council and Security Backup multisigs. NOTE: The last two are yet to be deployed.

@sajanrajdev sajanrajdev marked this pull request as draft August 27, 2024 14:02
@sajanrajdev sajanrajdev changed the title feat: badger governance audit feat: badger governance progression Aug 27, 2024
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review on scripts/badger/dev_multisig_progression.py and its update on governance across the board:

  1. grants role to techops in gac, guardian, kac, rl and badgertree ✅ . note that keeps the devmsig with DEFAULT_ADMIN_ROLE role for unknowns, no concern specially after the signer status update
  2. updates all gov from devmisig to timelock ✅ (admin of the timelock is the devmsig ideally on its new state)
  3. batches signers changes to reach final stage of eco-multisigs. script assets L160 final state as expected ✅

it follows the guidelines of our internal conversations, will be pendant still after these 3 actions work around GatedMiniMeController and Timelock to finalise all points. These items since requires potentially a modification in the Timelock will be handle separately

p.s: pendant of having 2 new msig addys (community and security backup). both will require to go thru usual steps of proving ownership via txs and liveness. currently they are with "placeholders"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants