Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: not using yieldApr for influence vault #2332

Merged
merged 1 commit into from
Aug 29, 2022
Merged

fix: not using yieldApr for influence vault #2332

merged 1 commit into from
Aug 29, 2022

Conversation

mranilrai
Copy link
Collaborator

On Staging

before after
Screenshot 2022-08-28 at 4 23 58 PM Screenshot 2022-08-28 at 4 24 20 PM

@mranilrai mranilrai requested a review from okjintao as a code owner August 28, 2022 10:57
@mranilrai mranilrai self-assigned this Aug 28, 2022
@mranilrai mranilrai linked an issue Aug 28, 2022 that may be closed by this pull request
bug: influence vaults do not scale apr correctly (v1.5) #2314
Closed
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟡 Statements 51.81% 2163/4175
🟡 Branches 44.42% 780/1756
🟡 Functions 44.9% 533/1187
🟢 Lines 69.24% 15228/21992

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from cff0ed5

@mranilrai mranilrai requested a review from mrbasado August 29, 2022 13:11
@okjintao okjintao added the enhancement New feature or request label Aug 29, 2022
@okjintao okjintao changed the title not using yieldApr for influence vault fix: not using yieldApr for influence vault Aug 29, 2022
@okjintao okjintao merged commit 5997eb6 into development Aug 29, 2022
@okjintao okjintao deleted the influence-vaults-do-not-scale-apr-correctly branch August 29, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okjintao okjintao okjintao approved these changes

@mrbasado mrbasado Awaiting requested review from mrbasado mrbasado is a code owner

Assignees

@mranilrai mranilrai

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: influence vaults do not scale apr correctly (v1.5)
2 participants
@mranilrai @okjintao