Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

staging deploy for apy evolution modal fix and links #2388

Merged
merged 6 commits into from
Sep 21, 2022
Merged

staging deploy for apy evolution modal fix and links #2388

merged 6 commits into from
Sep 21, 2022

Conversation

mrbasado
Copy link
Collaborator

No description provided.

@mrbasado mrbasado requested a review from okjintao as a code owner September 20, 2022 22:00
@mrbasado mrbasado changed the title staging deploy for apy evolution modal fix staging deploy for apy evolution modal fix and links Sep 21, 2022
GalloDaSballo
GalloDaSballo approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@GalloDaSballo GalloDaSballo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would advise with moving the check to a bigger component

sourceApr &&

This avoid showing the % by itself while also preventing the crash

GalloDaSballo
GalloDaSballo approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@GalloDaSballo GalloDaSballo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MB

@mrbasado mrbasado merged commit f59ad1e into staging Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalloDaSballo GalloDaSballo GalloDaSballo approved these changes

@okjintao okjintao Awaiting requested review from okjintao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrbasado @GalloDaSballo