Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to Reset and Retrieve a current sessions expiry #1036

Closed
Badgerati opened this issue Nov 29, 2022 · 1 comment · Fixed by #1047
Closed

Add a way to Reset and Retrieve a current sessions expiry #1036

Badgerati opened this issue Nov 29, 2022 · 1 comment · Fixed by #1047
Assignees
Milestone

Comments

@Badgerati
Copy link
Owner

Badgerati commented Nov 29, 2022

At the moment there isn't a way to reset a current session's expiry datetime, nor a clean way to retrieve the datetime the current session will expire.

This issue is to add, at least, the new functions:

  • Reset-PodeSessionExpiry
  • Get-PodeSessionExpiry
@Badgerati Badgerati moved this to Backlog in 🚀 Pode Roadmap Nov 29, 2022
@Badgerati Badgerati added this to the 2.8.0 milestone Nov 29, 2022
@Badgerati Badgerati changed the title New Update-PodeSessionExpiry to programmatically extend a session Add a way to Reset and Retrieve a current sessions expiry Dec 16, 2022
@Badgerati Badgerati self-assigned this Dec 16, 2022
@Badgerati Badgerati moved this from Backlog to In Progress in 🚀 Pode Roadmap Dec 16, 2022
Badgerati added a commit that referenced this issue Dec 16, 2022
@Badgerati
Copy link
Owner Author

The above commit adds the two functions mentioned originally, but also adds a new Get-PodeSessionDuration - so there's a way to retrieve the duration defined for each session afterwards.

I've also cleaned up the code around sessions and session cookies, including fixing a bug around non-extending sessions where their expiries were actually extending! I've also updated the Set-Cookie header builder to use StringBuilder rather than += - plus a couple other small performance tweaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant