You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the above lines, even if the URL doesn't contain a query string we're still running ParseQueryString on the URL. This means we will have a redundant empty NameValue pair in the returned collection, which is just the URL again.
Originally this didn't matter, but after #1066 which now allows empty keys in Query Strings to be possible, these redundant keys are now being allowed as well 😂 It's not much of an issue, but Pode.Web relies on the keys in the query string collection, and is now behaving ... funkily.
Plan: If the URL doesn't have ? just set the default NameValueCollection.
The text was updated successfully, but these errors were encountered:
Pode/src/Listener/PodeHttpRequest.cs
Lines 207 to 216 in 9b1456e
In the above lines, even if the URL doesn't contain a query string we're still running
ParseQueryString
on the URL. This means we will have a redundant empty NameValue pair in the returned collection, which is just the URL again.Originally this didn't matter, but after #1066 which now allows empty keys in Query Strings to be possible, these redundant keys are now being allowed as well 😂 It's not much of an issue, but Pode.Web relies on the keys in the query string collection, and is now behaving ... funkily.
Plan: If the URL doesn't have
?
just set the default NameValueCollection.The text was updated successfully, but these errors were encountered: