Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename functions so they have the Pode prefix #600

Closed
Badgerati opened this issue Aug 20, 2020 · 1 comment · Fixed by #601
Closed

Rename functions so they have the Pode prefix #600

Badgerati opened this issue Aug 20, 2020 · 1 comment · Fixed by #601
Assignees
@Badgerati
Labels
bug 🐛
Milestone
2.0.0

Comments

@Badgerati
Copy link
Owner

Describe the Bug

As pointed out by @Fraham, there are 4 functions in Pode that are missing the "Pode" prefix:

  • Test-IsEmpty
  • Test-IsUnix
  • Test-IsWindows
  • Test-IsPSCore

these should actually be:

  • Test-PodeIsEmpty
  • Test-PodeIsUnix
  • Test-PodeIsWindows
  • Test-PodeIsPSCore

to avoid conflicts with other modules.
@Badgerati Badgerati added this to the 2.0.0 milestone Aug 20, 2020
@Badgerati Badgerati self-assigned this Aug 20, 2020
@Badgerati
Copy link
Owner Author

Seems there's also another:

  • Test-IsAdminUser

Badgerati added a commit that referenced this issue Aug 20, 2020
@Badgerati
#600: ensure all functions have the Pode prefix
552c1e5
@Badgerati Badgerati mentioned this issue Aug 20, 2020
Merged
Badgerati added a commit that referenced this issue Aug 20, 2020
@Badgerati
#600: update migrate doc
fc8fd5e
@Badgerati Badgerati mentioned this issue Nov 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Badgerati Badgerati

Labels
bug 🐛
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

Ensure all functions have the Pode prefix Badgerati/Pode
1 participant
@Badgerati