Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Oauth 2.0 authentication with redirect_uri while Pode is hosted on IIS #636

Closed
nivsteinberg opened this issue Dec 1, 2020 · 2 comments · Fixed by #637
Closed

Using Oauth 2.0 authentication with redirect_uri while Pode is hosted on IIS #636

nivsteinberg opened this issue Dec 1, 2020 · 2 comments · Fixed by #637
Assignees
Labels
Milestone

Comments

@nivsteinberg
Copy link

Describe the Bug

Since hosting pode on IIS force all endpoints to http://127.0.0.1 internally, Pode supplies the clients a defualt redirect_uri relative to loaclhost, while it should be transparent to him and they need a url relative to the hosaname and the port of the binding and not port 80.

Expected Behavior

Client should get redirect_uri relative to the hostaname in the IIS binding
for example, if hostname = pode.com with port 443
then redirect_uri = https://pode.com/oauth2/callback (while the internal route should be http://localhost/oauth2/callback, but our clients should be directed to the public address)

  • Versions:
    • Pode 2.0
    • IIS
@Badgerati
Copy link
Owner

Hey @nivsteinberg,

The above commit should resolve the issue when hosting via IIS. I tested with my own test site, and redirection worked as expected. Are you able to test the new logic yourself?

@Badgerati Badgerati added this to the 2.0.2 milestone Dec 2, 2020
@nivsteinberg
Copy link
Author

I tested it in my environment, and it worked as expected 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants