Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MIME types to comply with RFC9512 and RFC5323 #1352

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Update MIME types to comply with RFC9512 and RFC5323 #1352

merged 3 commits into from
Jul 8, 2024

Conversation

mdaneri
Copy link
Contributor

@mdaneri mdaneri commented Jul 6, 2024 •
edited
Loading

Details:

  • Updated MIME type handling to accommodate the new application/yaml type as specified in RFC9512.
  • Changed application/x-yaml and text/x-yaml to application/yaml.
  • Changed text/xml to application/xml in accordance with the recommendations of RFC5323.

These changes ensure that Pode is compliant with the latest MIME type standards and improves compatibility with applications that rely on these MIME types.

Changes:

  • Added support for application/yaml.
  • Replaced all instances of application/x-yaml and text/x-yaml with application/yaml.
  • Replaced all instances of text/xml with application/xml.

@mdaneri mdaneri changed the title Rfc9512 Update MIME types to comply with RFC9512 and RFC5323 Jul 6, 2024
Badgerati
Badgerati requested changes Jul 7, 2024
View reviewed changes
Copy link
Owner

@Badgerati Badgerati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the 2 minor change comments, everything else LGTM

src/Public/Responses.ps1 Outdated Show resolved Hide resolved
src/Public/Responses.ps1 Outdated Show resolved Hide resolved
@Badgerati Badgerati added this to the 2.11.0 milestone Jul 7, 2024
@Badgerati Badgerati merged commit 473123b into Badgerati:develop Jul 8, 2024
14 checks passed
@Badgerati Badgerati mentioned this pull request Sep 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badgerati Badgerati Badgerati approved these changes

Assignees

@mdaneri mdaneri

Labels
enhancement ⬆️
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mdaneri @Badgerati