Refactor Byte Conversion Functions; Remove Duplicate Task Process Definitions #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Summary of Changes:
1. **Removed `ConvertFrom-PodeValueToByteArray`**:
- The function `ConvertFrom-PodeValueToByteArray` has been removed as it's no longer needed.
2. **Updated Encoding Logic in `Response.ps1`**:
- In `Public/Response.ps1`, line 219, the following change was made:
- Replaced:
```powershell
$Bytes = ConvertFrom-PodeValueToByteArray -Value $Value
```
- With:
```powershell
$Bytes = [System.Text.Encoding]::UTF8.GetBytes($Value)
```
3. **Removed Duplicated `Get-PodeTaskProcess`**:
- The function `Get-PodeTaskProcess` had a duplicate definition, which has been removed.
4. **Renamed `ConvertFrom-PodeValueToByteArray` to `ConvertFrom-PodeStreamToByteArray`**:
- The remaining instances of `ConvertFrom-PodeValueToByteArray` were renamed to `ConvertFrom-PodeStreamToByteArray` to reflect its actual functionality and improve clarity.
Badgerati
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes:
Removed
ConvertFrom-PodeValueToByteArray:ConvertFrom-PodeValueToByteArrayhas been removed as it's no longer needed.Updated Encoding Logic in
Response.ps1:Public/Response.ps1, line 219, the following change was made:Replaced:
With:
Removed Duplicated
Get-PodeTaskProcess:Get-PodeTaskProcesshad a duplicate definition, which has been removed.Renamed
ConvertFrom-PodeValueToByteArraytoConvertFrom-PodeStreamToByteArray:ConvertFrom-PodeValueToByteArraywere renamed toConvertFrom-PodeStreamToByteArrayto reflect its actual functionality and improve clarity.