Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selector bug #3

Merged
merged 4 commits into from
Feb 23, 2017
Merged

Fix selector bug #3

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3134694
fix ampersand selector bug
tomm1996 Feb 23, 2017
3d84a9a
build files after hotfix
tomm1996 Feb 23, 2017
6fb0790
remove ampersand from utilities
tomm1996 Feb 23, 2017
83979ce
added missing ampersands
tomm1996 Feb 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/gutenberg.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,7 @@ body {
padding-top: 2.54cm;
padding-bottom: 2.54cm; }

a[href^="http://"]:after, [href^="https://"]:after, [href^="ftp://"]:after {
a [href^="http://"]:after, a [href^="https://"]:after, a [href^="ftp://"]:after {
content: " (" attr(href) ")";
font-size: 80%; }

Expand Down
2 changes: 1 addition & 1 deletion dist/gutenberg.min.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 6 additions & 4 deletions scss/_reformat.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
// Show link source
// For fully qualified URLs only
a[href^="http://"], &[href^="https://"], &[href^="ftp://"] {
&:after {
content: " (" attr(href) ")";
font-size: 80%;
a {
[href^="http://"], [href^="https://"], [href^="ftp://"] {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing & here. Have a look at the compiled CSS

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, I fixed that now in 83979ce

&:after {
content: " (" attr(href) ")";
font-size: 80%;
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion scss/_utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ a.no-reformat:after {
content: ""
}

&abbr[title], &acronym[title] {
abbr[title], acronym[title] {
&.no-reformat:after {
content: ""
}
Expand Down