BAH-4029 | adding better logs in cases of outside range values or inv…

…alid values for coded answers (#269) * BAH-4029 | Logging better logs in cases of outside range values or invalid values for coded answers * BAH-4029 | minor improvement - adding a gaurd clause to check if concept is numeric
Bahmni · Jul 19, 2024 · c53f6f7 · c53f6f7
1 parent 6359f3c
commit c53f6f7
Showing 1 changed file with 26 additions and 2 deletions.
diff --git a/...i/src/main/java/org/openmrs/module/bahmniemrapi/laborder/mapper/LabOrderResultMapper.java b/...i/src/main/java/org/openmrs/module/bahmniemrapi/laborder/mapper/LabOrderResultMapper.java
@@ -4,6 +4,7 @@
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.openmrs.Concept;
+import org.openmrs.ConceptNumeric;
 import org.openmrs.Obs;
 import org.openmrs.Order;
 import org.openmrs.api.APIException;
@@ -14,13 +15,15 @@
 
 import java.text.ParseException;
 import java.util.Date;
+import java.util.Optional;
 
 import static org.apache.commons.lang3.StringUtils.isEmpty;
 import static org.apache.commons.lang3.StringUtils.isNotBlank;
 
 @Component
 public class LabOrderResultMapper {
     private static final Log log = LogFactory.getLog(LabOrderResultMapper.class);
+    private static final String EMPTY_STRING = "";
     public static final String LAB_RESULT = "LAB_RESULT";
     public static final String LAB_ABNORMAL = "LAB_ABNORMAL";
     public static final String LAB_MINNORMAL = "LAB_MINNORMAL";
@@ -72,13 +75,14 @@ private Obs newResultObs(Order testOrder, Date obsDate, Concept concept, LabOrde
         obs.setConcept(concept);
         obs.setOrder(testOrder);
         obs.setObsDatetime(obsDate);
+        String accessionUuid = Optional.ofNullable(labOrderResult.getAccessionUuid()).orElseGet(() -> Optional.ofNullable(obs.getOrder()).map(Order::getAccessionNumber).orElse(EMPTY_STRING));
         if (concept.getDatatype().getHl7Abbreviation().equals("CWE")) {
             String resultUuid = labOrderResult.getResultUuid();
             Concept conceptAnswer = isEmpty(resultUuid) ? null : conceptService.getConceptByUuid(resultUuid);
                 obs.setValueCoded(conceptAnswer);
             if (conceptAnswer == null) {
-                log.warn(String.format("Concept is not available in OpenMRS for ConceptUuid : [%s] , In Accession : [%s]"
-                        , resultUuid,labOrderResult.getAccessionUuid()));
+                log.error(String.format("Concept [%s] does not not have coded answer with ConceptUuid [%s] in OpenMRS, In Accession [%s]",
+                        obs.getConcept().getName(), resultUuid, accessionUuid));
                 return null;
             }
             return obs;
@@ -88,9 +92,29 @@ private Obs newResultObs(Order testOrder, Date obsDate, Concept concept, LabOrde
             return null;
         }
         obs.setValueAsString(labOrderResult.getResult());
+        checkResultRangesForAbsolutes(obs, accessionUuid);
         return obs;
     }
 
+    /**
+     * This method just logs error if the results are out of absolute ranges. This will be errored out (ValidationException)
+     * by openmrs by the {@link org.openmrs.validator.ObsValidator} during save
+     */
+    private void checkResultRangesForAbsolutes(Obs obs, String accessionUuid) {
+        if (!obs.getConcept().isNumeric()) {
+            return;
+        }
+        if (obs.getValueNumeric() != null) {
+            ConceptNumeric cn = (ConceptNumeric) obs.getConcept();
+            if (cn.getHiAbsolute() != null && cn.getHiAbsolute() < obs.getValueNumeric()) {
+                log.error(String.format("Test results for [%s] is beyond the absolute high range, in Accession [%s]", cn.getName(), accessionUuid));
+            }
+            if (cn.getLowAbsolute() != null && cn.getLowAbsolute() > obs.getValueNumeric()) {
+                log.error(String.format("Test results for [%s] is beyond the absolute low range, in Accession [%s]", cn.getName(), accessionUuid));
+            }
+        }
+    }
+
     private Concept getConceptByName(String conceptName) {
         return conceptService.getConceptByName(conceptName);
     }