Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace eval with getattr #5

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Replace eval with getattr #5

wants to merge 3 commits into from

Conversation

till-m
Copy link

@till-m till-m commented Dec 13, 2023

@PoopBear1
Copy link

Replace "eval" might cause issues when you are not using Linear-Lora, for example when using the inherited Multihead Class.

@till-m
Copy link
Author

till-m commented Mar 15, 2024

Hi @PoopBear1,

thanks for the heads-up. I remember using the MHA without issue, though it has admittedly been a while. DId you run into any troubles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@till-m @PoopBear1