Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use replace_methods: false by default in loaders #28

Closed
Bajena opened this issue Jun 2, 2019 · 0 comments · Fixed by #29
Closed

Use replace_methods: false by default in loaders #28

Bajena opened this issue Jun 2, 2019 · 0 comments · Fixed by #29

Comments

@Bajena
Copy link
Owner

Bajena commented Jun 2, 2019

Recently a new option replace_methods got introduced to batch loader (exAspArk/batch-loader#45).
I did some benchmarking on serializing ActiveRecord models both for replace_methods = true and replace_methods = false and on average false was more than 2x faster.

Let's use false as default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use replace_methods: false in batch loaders Bajena/ams_lazy_relationships
1 participant
@Bajena