Implementation of sketch_vector #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s with blas::Op:Trans on vectors and renamed test_sketch_vec to test_sketch_vec_wide
|
@rileyjmurray Hi Riley. I finished the testing that you requested on Friday. I also added the documentation for sketch_vector. I'm unsure how to see if it looks good. Let me know what you think. Thanks! |
rileyjmurray
requested changes
Sep 29, 2023
There was a problem hiding this comment.
Thanks for your patience, @kaiwenhe7. I've left a large number of comments about the documentation for sketch_vector. I'd also like you to make a wrapper for sketch_vector which automatically sets i_off = j_off = 0 (you can't do this with default arguments since there are arguments without defaults that follow).
test/test_dense/test_sketch_gefl3.cc
Outdated
|
|
||
| // Generate wide sketching operator | ||
| RandBLAS::DenseDist D(d, m); | ||
| RandBLAS::DenseSkOp<double> S_wide(D, seed, nullptr); |
There was a problem hiding this comment.
If you template on T then you should use RandBLAS::DenseSkOp<T>, not RandBLAS::DenseSkOp<double>.
rileyjmurray
changed the title
tweak
doc tweaks
more doc tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created sketch_vector function in skge.hh and added unit test test_sketch_vec