feat: comet library #176
Merged
feat: comet library #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Slither reportTHIS CHECKLIST IS NOT COMPLETE. Use |
0xsambugs
commented
Jan 24, 2025
| @@ -268,6 +268,7 @@ abstract contract CompoundV3Connector is BaseConnector, Initializable { | |||
| uint256 rewardBalance = 0; | |||
| address rewardToken = cometRewards_.rewardConfig(address(cToken_)).token; | |||
| if (rewardToken != address(0)) { | |||
| // TODO: check if there is something to claim | |||
There was a problem hiding this comment.
We should check if there is something to claim before claiming it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things. First, it introduces
LibComet. This library reproduces some of the logic inside Comet's code to be able to calculate the amount of rewards owed to a certain account. But we do so in aviewmanner, without modifying the stateThen, this PR also introduces
CometRewardsTracker. A new contract that exposes the code inLibComet, so that we can use it from our connector (this will done in another PR)Testing
In order to make sure that this works as expected, we've done the following:
CometRewardsTrackerthat would compare our code's results with Comet's